From 1c505b3b4563203ec4b525e425d302840b677461 Mon Sep 17 00:00:00 2001 From: BONNEVILLE Geoffroy Date: Thu, 21 Dec 2017 15:13:31 +0100 Subject: [PATCH] Updated some TODOs with info on probable error causes Changed visibility from Invisible to Gone on task lists --- .../com/wismna/geoffroy/donext/fragments/MainFragment.java | 4 ++-- .../com/wismna/geoffroy/donext/fragments/TasksFragment.java | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/com/wismna/geoffroy/donext/fragments/MainFragment.java b/app/src/main/java/com/wismna/geoffroy/donext/fragments/MainFragment.java index 5988c06..3d40e7a 100644 --- a/app/src/main/java/com/wismna/geoffroy/donext/fragments/MainFragment.java +++ b/app/src/main/java/com/wismna/geoffroy/donext/fragments/MainFragment.java @@ -101,7 +101,7 @@ public class MainFragment extends Fragment implements TasksFragment.TaskChangedA tabLayout = mView.findViewById(R.id.tabs); // Hide the tabs if there is only one task list - if (taskLists.size() == 1) tabLayout.setVisibility(View.INVISIBLE); + if (taskLists.size() == 1) tabLayout.setVisibility(View.GONE); tabLayout.setupWithViewPager(mViewPager); // Handles scroll detection (only available for SDK version >=23) @@ -119,7 +119,7 @@ public class MainFragment extends Fragment implements TasksFragment.TaskChangedA else { ListView listView = mView.findViewById(R.id.list); // Hide the list if there is only one task list - if (taskLists.size() == 1) listView.setVisibility(View.INVISIBLE); + if (taskLists.size() == 1) listView.setVisibility(View.GONE); //listView.setAdapter(new ArrayAdapter<>(this, android.R.layout.simple_list_item_1, taskLists)); listView.setAdapter(new ArrayAdapter<>(activity, R.layout.list_tasklist_item, taskLists)); //listView.setSelection(lastOpenedList); diff --git a/app/src/main/java/com/wismna/geoffroy/donext/fragments/TasksFragment.java b/app/src/main/java/com/wismna/geoffroy/donext/fragments/TasksFragment.java index 6e2bf73..abfab19 100644 --- a/app/src/main/java/com/wismna/geoffroy/donext/fragments/TasksFragment.java +++ b/app/src/main/java/com/wismna/geoffroy/donext/fragments/TasksFragment.java @@ -92,7 +92,7 @@ public class TasksFragment extends Fragment implements Activity parentActivity = getActivity(); if (parentActivity instanceof HistoryActivity) isHistory = true; if (parentActivity instanceof TodayActivity) isTodayView = true; - // TODO: check that this works! + // TODO: this does not work! No tasks are shown mAdapter = (MainFragment)getParentFragment(); } } @@ -118,6 +118,7 @@ public class TasksFragment extends Fragment implements } recyclerView.setAdapter(taskRecyclerViewAdapter); + // TODO: check that this works if (!isHistory) { // Set ItemTouch helper in RecyclerView to handle swipe move on elements ItemTouchHelper.Callback callback = new TaskTouchHelper(this,