Move finally works

Sort entries and groups refresh page info
Stopped using breadcrumb user control - for now
Some refactoring

ModernKeePass/Views/UserControls/BreadCrumbUserControl.xaml

@@ -16,7 +16,11 @@
         </ItemsControl.ItemsPanel>
         <ItemsControl.Resources>
             <DataTemplate x:Name="FirstItemTemplate">
-                <HyperlinkButton Foreground="{StaticResource MainColor}" Content="{Binding Title}" Style="{StaticResource MainColorHyperlinkButton}" FontWeight="Light" FontSize="12" Padding="0">
+                <HyperlinkButton 
+                    FontWeight="Light" FontSize="12" Padding="0"
+                    Foreground="{StaticResource MainColor}" 
+                    Content="{Binding Title}" 
+                    Style="{StaticResource MainColorHyperlinkButton}">
                     <interactivity:Interaction.Behaviors>
                         <core:EventTriggerBehavior EventName="Click">
                             <core:NavigateToPageAction Parameter="{Binding Id}" TargetPage="ModernKeePass.Views.GroupDetailPage" />

ModernKeePass/Views/UserControls/TopMenuUserControl.xaml

@@ -56,10 +56,9 @@
                     </ToolTipService.ToolTip>
                 </SymbolIcon>
                 <Button.Flyout>
-                    <Flyout>
+                    <Flyout Opening="MoveButtonFlyout_OnOpening">
                         <StackPanel>
-                            <SearchBox 
-                                x:Uid="GroupsSearch" 
+                            <SearchBox x:Uid="GroupsSearch" 
                                 Padding="12" Width="350"
                                 Margin="0,5,0,5" 
                                 FontSize="15" 
@@ -68,7 +67,7 @@
                                 SearchHistoryEnabled="False"
                                 Style="{StaticResource MainColorSearchBox}">
                             </SearchBox>
-                            <Button x:Uid="MoveButton" Command="{Binding MoveCommand, ElementName=UserControl}" CommandParameter="{Binding SelectedDestinationGroup}" Style="{StaticResource MainColorButton}" />
+                            <Button x:Name="MoveButton" x:Uid="MoveButton" Style="{StaticResource MainColorButton}" />
                         </StackPanel>
                     </Flyout>
                 </Button.Flyout>
@@ -100,7 +99,7 @@
                     </ToolTipService.ToolTip>
                 </SymbolIcon>
             </ToggleButton>
-            <Button Command="{Binding DeleteCommand, ElementName=UserControl}" IsEnabled="{Binding IsDeleteButtonEnabled, ElementName=UserControl}" Click="DeleteButton_Click" Style="{StaticResource MenuButtonStyle}">
+            <Button Command="{Binding DeleteCommand, ElementName=UserControl}" Style="{StaticResource MenuButtonStyle}">
                 <SymbolIcon Symbol="Delete">
                     <ToolTipService.ToolTip>
                         <ToolTip x:Uid="TopMenuDeleteButton" />
@@ -112,13 +111,13 @@
             <SymbolIcon Symbol="More" />
             <Button.Flyout>
                 <MenuFlyout Opening="OverflowFlyout_OnOpening">
-                    <MenuFlyoutItem x:Uid="TopMenuSaveFlyout" Command="{Binding SaveCommand, ElementName=UserControl}" />
+                    <MenuFlyoutItem x:Uid="TopMenuSaveFlyout" x:Name="SaveFlyout" />
                     <MenuFlyoutItem x:Uid="TopMenuMoveFlyout" x:Name="MoveFlyout" Visibility="{Binding MoveButtonVisibility, ElementName=UserControl}" />
-                    <MenuFlyoutItem x:Uid="TopMenuRestoreFlyout" x:Name="RestoreFlyout" Command="{Binding RestoreCommand, ElementName=UserControl}" Visibility="{Binding RestoreButtonVisibility, ElementName=UserControl}" />
-                    <ToggleMenuFlyoutItem x:Uid="TopMenuEditFlyout" x:Name="EditFlyout" Command="{Binding EditCommand, ElementName=UserControl}" IsChecked="{Binding IsEditButtonChecked, ElementName=UserControl, Mode=TwoWay}" Click="EditButton_Click" />
-                    <MenuFlyoutItem x:Uid="TopMenuDeleteFlyout" x:Name="DeleteFlyout" Command="{Binding DeleteCommand, ElementName=UserControl}" IsEnabled="{Binding IsDeleteButtonEnabled, ElementName=UserControl}" Click="DeleteButton_Click" />
-                    <MenuFlyoutItem x:Uid="TopMenuSortEntriesFlyout" x:Name="SortEntriesFlyout" Command="{Binding SortEntriesCommand, ElementName=UserControl}" Visibility="{Binding SortButtonVisibility, ElementName=UserControl}" />
-                    <MenuFlyoutItem x:Uid="TopMenuSortGroupsFlyout" x:Name="SortGroupsFlyout" Command="{Binding SortGroupsCommand, ElementName=UserControl}" Visibility="{Binding SortButtonVisibility, ElementName=UserControl}" />
+                    <MenuFlyoutItem x:Uid="TopMenuRestoreFlyout" x:Name="RestoreFlyout" Visibility="{Binding RestoreButtonVisibility, ElementName=UserControl}" />
+                    <ToggleMenuFlyoutItem x:Uid="TopMenuEditFlyout" x:Name="EditFlyout" IsChecked="{Binding IsEditButtonChecked, ElementName=UserControl, Mode=TwoWay}" Click="EditButton_Click" />
+                    <MenuFlyoutItem x:Uid="TopMenuDeleteFlyout" x:Name="DeleteFlyout" />
+                    <MenuFlyoutItem x:Uid="TopMenuSortEntriesFlyout" x:Name="SortEntriesFlyout" Visibility="{Binding SortButtonVisibility, ElementName=UserControl}" />
+                    <MenuFlyoutItem x:Uid="TopMenuSortGroupsFlyout" x:Name="SortGroupsFlyout" Visibility="{Binding SortButtonVisibility, ElementName=UserControl}" />
                 </MenuFlyout>
             </Button.Flyout>
         </Button>

ModernKeePass/Views/UserControls/TopMenuUserControl.xaml.cs

@@ -134,18 +134,6 @@ namespace ModernKeePass.Views.UserControls
                 typeof(Visibility),
                 typeof(TopMenuUserControl),
                 new PropertyMetadata(Visibility.Collapsed, (o, args) => { }));
-
-        public bool IsDeleteButtonEnabled
-        {
-            get { return (bool)GetValue(IsDeleteButtonEnabledProperty); }
-            set { SetValue(IsDeleteButtonEnabledProperty, value); }
-        }
-        public static readonly DependencyProperty IsDeleteButtonEnabledProperty =
-            DependencyProperty.Register(
-                nameof(IsDeleteButtonEnabled),
-                typeof(bool),
-                typeof(TopMenuUserControl),
-                new PropertyMetadata(true, (o, args) => { }));
         
         public bool IsEditButtonChecked
         {
@@ -160,7 +148,6 @@ namespace ModernKeePass.Views.UserControls
                 new PropertyMetadata(false, (o, args) => { }));
         
         public event EventHandler<RoutedEventArgs> EditButtonClick;
-        public event EventHandler<RoutedEventArgs> DeleteButtonClick;
         
         public TopMenuUserControl()
         {
@@ -179,27 +166,28 @@ namespace ModernKeePass.Views.UserControls
             EditButtonClick?.Invoke(sender, e);
         }
 
-        private void DeleteButton_Click(object sender, RoutedEventArgs e)
-        {
-            DeleteButtonClick?.Invoke(sender, e);
-        }
-
         private void OverflowFlyout_OnOpening(object sender, object e)
         {
-            DeleteFlyout.IsEnabled = IsDeleteButtonEnabled;
-            DeleteFlyout.IsEnabled = IsDeleteButtonEnabled;
-
             EditFlyout.IsChecked = IsEditButtonChecked;
 
             MoveFlyout.Visibility = MoveButtonVisibility;
             RestoreFlyout.Visibility = RestoreButtonVisibility;
-
             SortEntriesFlyout.Visibility = SortButtonVisibility;
             SortGroupsFlyout.Visibility = SortButtonVisibility;
+
+            SaveFlyout.Command = SaveCommand;
+            DeleteFlyout.Command = DeleteCommand;
+            RestoreFlyout.Command = RestoreCommand;
             SortEntriesFlyout.Command = SortEntriesCommand;
             SortGroupsFlyout.Command = SortGroupsCommand;
         }
 
+        // These are somehow necessary as otherwise, the command is not bound
+        private void MoveButtonFlyout_OnOpening(object sender, object e)
+        {
+            MoveButton.Command = MoveCommand;
+        }
+
         private void SortFlyout_OnOpening(object sender, object e)
         {
             SortEntriesButtonFlyout.Command = SortEntriesCommand;
@@ -209,15 +197,21 @@ namespace ModernKeePass.Views.UserControls
         private void SearchBox_OnSuggestionsRequested(SearchBox sender, SearchBoxSuggestionsRequestedEventArgs args)
         {
             var imageUri = RandomAccessStreamReference.CreateFromUri(new Uri("ms-appdata://Assets/ModernKeePass-SmallLogo.scale-80.png"));
-            foreach (var group in Model.Groups.Where(g => g.Title.IndexOf(args.QueryText, StringComparison.OrdinalIgnoreCase) >= 0))
+            var groups = Model.Groups.Where(g => g.Title.IndexOf(args.QueryText, StringComparison.OrdinalIgnoreCase) >= 0).Take(5);
+            foreach (var group in groups)
             {
-                args.Request.SearchSuggestionCollection.AppendResultSuggestion(group.Title, group.ParentGroupName, group.Id, imageUri, string.Empty);
+                args.Request.SearchSuggestionCollection.AppendResultSuggestion(
+                    group.Title, 
+                    group.ParentGroupName, 
+                    group.Id, 
+                    imageUri, 
+                    string.Empty);
             }
         }
 
         private void SearchBox_OnResultSuggestionChosen(SearchBox sender, SearchBoxResultSuggestionChosenEventArgs args)
         {
-            Model.SelectedDestinationGroup = args.Tag;
+            MoveButton.CommandParameter = args.Tag;
             MoveCommand.RaiseCanExecuteChanged();
         }
     }