wismna/donext
1
0
Fork 0
mirror of https://github.com/wismna/DoNext.git synced 2025-10-03 07:30:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

Correction of a tricky bug in Edit Task lists: a final position int was passed to two listeners, even though the position might change. So the first value was always used. Change is to determine position at runtime and not use a final int.

Browse Source
This commit is contained in:
geoffroy
2016-01-27 17:33:56 -05:00
parent 133df4c414
commit c90cc766a1
3 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
DoNExt/app/src/main/AndroidManifest.xml
View File

@@ -17,7 +17,7 @@
<category android:name="android.intent.category.LAUNCHER" />
</intent-filter>
</activity>
</activity>18,
<activity
android:name=".activities.SettingsActivity"
android:label="@string/action_settings"

10
DoNExt/app/src/main/java/com/wismna/geoffroy/donext/adapters/TaskListRecyclerViewAdapter.java
View File

@@ -48,7 +48,7 @@ public class TaskListRecyclerViewAdapter extends RecyclerView.Adapter<TaskListRe
}
@Override
public void onBindViewHolder(final ViewHolder holder, final int position) {
public void onBindViewHolder(final ViewHolder holder, int position) {
holder.mItem = mValues.get(position);
holder.mTaskCountView.setText(String.valueOf(mValues.get(position).getTaskCount()));
holder.mTaskNameView.setText(mValues.get(position).getName());
@@ -74,7 +74,7 @@ public class TaskListRecyclerViewAdapter extends RecyclerView.Adapter<TaskListRe
if (!hasFocus && !holder.mItem.getName().matches(name)) {
holder.mItem.setName(name);
update(holder.mItem, position);
update(holder.mItem, holder.getAdapterPosition());
mListener.onEditTextLoseFocus(holder.mItem);
}
}
@@ -84,11 +84,11 @@ public class TaskListRecyclerViewAdapter extends RecyclerView.Adapter<TaskListRe
holder.mTaskDeleteButton.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
// Disable the OnFocusChanged listener as it is pointless now
// Disable the OnFocusChanged listener as it is now pointless and harmful
holder.mTaskNameView.setOnFocusChangeListener(null);
//remove(position);
mListener.onClickDeleteButton(position, holder.mItem.getId());
mListener.onClickDeleteButton(holder.getAdapterPosition(), holder.mItem.getId());
}
});
}
@@ -104,8 +104,8 @@ public class TaskListRecyclerViewAdapter extends RecyclerView.Adapter<TaskListRe
}
public void remove(int position) {
notifyItemRemoved(position);
mValues.remove(position);
notifyItemRemoved(position);
}
public void update(TaskList item, int position) {

3
DoNExt/app/src/main/java/com/wismna/geoffroy/donext/adapters/TaskRecyclerViewAdapter.java
View File

@@ -94,8 +94,7 @@ public class TaskRecyclerViewAdapter extends RecyclerView.Adapter<TaskRecyclerVi
notifyItemRemoved(position);
}
public void update(Task item, int position)
{
public void update(Task item, int position) {
mValues.set(position, item);
notifyItemChanged(position);
}